Improve configuration

Repository details (fly-the-rainbow-flag.com)
Project log category
(118 entries)
Owner
@joelpurra
Contributors
Contributors on Github
Project status
⏲️ This project has had recent commits.
📂 This project is open.
🤷 This project is not particularly popular.
Repository activity period
🗓
Commits
118 commits
Stars
2 stars
Commit details (179fee0a)
Author
Authored at
Committer
Joel Purra
Committed at

Commit message

Improve configuration

  • Add basic configuration assertion failure messages
  • Parse and handle non-string configuration values.
    • Opted not to use parseValues from nconf through configvention, but if separated it could be an option.
  • Configuration name underscores to support environment variables.
  • Rename AWS configuration names to match the ones officially used by aws-sdk.
    • Since configvention configuration values may be loaded from file (and not injected into process.env), they may_ not get picked up by aws-sdk. To be sure, they need to be injected manually.
  • Add ftrf "vendor" configuration name prefix to separate from other (prefixed) vendors.
Raw text
Improve configuration

- Add basic configuration assertion failure messages
- Parse and handle non-string configuration values.
  - Opted not to use `parseValues` from `nconf` through `configvention`, but if separated it could be an option.
- Configuration name underscores to support environment variables.
- Rename AWS configuration names to match the ones officially used by `aws-sdk`.
  - Since `configvention` configuration values may be loaded from file (and not _injected into `process.env`), they_ may_ not get picked up by `aws-sdk`. To be sure, they need to be injected manually.
- Add `ftrf` "vendor" configuration name prefix to separate from other (prefixed) vendors.

Changed files (7)

Path Additions Deletions
app/handlers/handle-upload.js +7 -4
app/lib/configuration.js +76 -43
app/lib/configured-https-redirect.js +7 -11
app/lib/get-s3-url.js +5 -2
app/lib/logger.js +5 -5
app/web.js +18 -10
app/web.js.defaults.config.json +16 -13

Commit categories (3)