Fix grouping voices per language/dialect
Repository details (talkie)
- Project page
- talkie
- Project log category
- talkie (734 entries)
- Repository
- @joelpurra/talkie
- Owner
- @joelpurra
- Issues
- Issues on Github
- Contributors
- Contributors on Github
- Project status
- ⏲️ This project has had recent commits.
- 📂 This project is open.
- 🌠 This project is popular.
- Repository activity period
- 🗓—
- Commits
- 770 commits
- Stars
- 79 stars
Commit details (4bc55fd6)
- Author
- Joel Purra
- Authored at
- Committer
- Joel Purra
- Committed at
Commit message
Fix grouping voices per language/dialect
- The grouping of voices per language or dialect is used when browsing and selecting voices in the user interface.
- During code refactoring and cleanup the grouping broke, leaving only a single voice per language or dialect.
- The issue was not noticed during development in part due to having either too few or too many voices when testing in browsers on the primary developer machine.
- Chome: 19 voices (14 languages, 18 dialects) -- only one dialect with two voices.
- Firefox: 14805 voices (119 languages, 134 dialects) -- too many language/dialect choices to notice lack of voice choices.
- The issue could have been avoided by writing proper unit tests, in particular before refactoring.
Raw text
Fix grouping voices per language/dialect - The grouping of voices per language or dialect is used when browsing and selecting voices in the user interface. - During code refactoring and cleanup the grouping broke, leaving only a single voice per language or dialect. - The issue was not noticed during development in part due to having either too few or too many voices when testing in browsers on the primary developer machine. - Chome: 19 voices (14 languages, 18 dialects) -- only one dialect with two voices. - Firefox: 14805 voices (119 languages, 134 dialects) -- too many language/dialect choices to notice lack of voice choices. - The issue could have been avoided by writing proper unit tests, in particular before refactoring.