Joel Purra: Developer and more


Move some assertions to options application selectors

Repository details (talkie)
Project page
talkie
Project category
(588 entries)
Repository
talkie on Github@joelpurra/talkie
Owner
joelpurra on Github@joelpurra
Commit details (3cf2fd27)
Author
Authored at
Commiter
Joel Purra
Commited at

Commit message

Move some assertions to options application selectors

- To see/set voice settings on the options page, the user drills down via language groups, dialects, and voices.
- Some "levels" expect the previous the previous levels to provide valid choices.
- To simplify the lower levels, some type assertions were moved to selectors.
- Can be further improved by splitting the `voices` slice into language groups, dialects, voices.
  - Splitting should reduce the need to assert values on each layers.
  - Splitting should also simplify each slice.
  - Should consider a `.../features/...` type directories, where slices/selectors/components/API/styling are grouped together by feature/functionality.

Changed files (6)

Commit categories (3)