Move some assertions to options application selectors
Repository details (talkie)
- Project page
- talkie
- Project log category
- talkie (708 entries)
- Repository
- @joelpurra/talkie
- Owner
- @joelpurra
- Issues
- Issues on Github
- Contributors
- Contributors on Github
- Project status
- ⏲️ This project has had recent commits.
- 📂 This project is open.
- 🌠 This project is popular.
- Repository activity period
- 🗓—
- Commits
- 751 commits
- Stars
- 71 stars
Commit details (3cf2fd27)
- Author
- Joel Purra
- Authored at
- Committer
- Joel Purra
- Committed at
Commit message
Move some assertions to options application selectors
- To see/set voice settings on the options page, the user drills down via language groups, dialects, and voices.
- Some "levels" expect the previous the previous levels to provide valid choices.
- To simplify the lower levels, some type assertions were moved to selectors.
- Can be further improved by splitting the
voicesslice into language groups, dialects, voices.
- Splitting should reduce the need to assert values on each layers.
- Splitting should also simplify each slice.
- Should consider a
.../features/...type directories, where slices/selectors/components/API/styling are grouped together by feature/functionality.
Raw text
Move some assertions to options application selectors - To see/set voice settings on the options page, the user drills down via language groups, dialects, and voices. - Some "levels" expect the previous the previous levels to provide valid choices. - To simplify the lower levels, some type assertions were moved to selectors. - Can be further improved by splitting the `voices` slice into language groups, dialects, voices. - Splitting should reduce the need to assert values on each layers. - Splitting should also simplify each slice. - Should consider a `.../features/...` type directories, where slices/selectors/components/API/styling are grouped together by feature/functionality.