Do not rehydrate state from local storage
Repository details (talkie)
- Project page
- talkie
- Project log category
- talkie (588 entries)
- Repository
- @joelpurra/talkie
- Owner
- @joelpurra
- Issues
- Issues on Github
- Contributors
- Contributors on Github
- Project status
- ⏲️ This project has had recent commits.
- 📂 This project is open.
- 🌠 This project is popular.
- Repository activity period
- 🗓—
- Commits
- 630 commits
- Stars
- 71 stars
Commit details (3bd88dcc)
- Author
- Joel Purra
- Authored at
- Committer
- Joel Purra
- Committed at
Commit message
Do not rehydrate state from local storage
- With pre-rendered html containing most state, the local storage state rehyration has lost some value in terms of speeding up rendering.
- For loading the remaining browser runtime dependent state (primarily the list of voices), it is now fast enough to not notice.
- Hydrating the state, if it has changed, requires one more rendering pass, and it might conflict (even flip-flop) with state updates performed when components mount.
- Putting more state in the prerendered html makes more sense.
- The features in
redux-persist-crosstab
are still fun-to-have, even though limited to a narrow scope in terms of usefulness.- For now keeping
redux-persist
to enableredux-persist-crosstab
, but disabling state rehydration from local storage.
Raw text
Do not rehydrate state from local storage - With pre-rendered html containing most state, the local storage state rehyration has lost some value in terms of speeding up rendering. - For loading the remaining browser runtime dependent state (primarily the list of voices), it is now fast enough to not notice. - Hydrating the state, if it has changed, requires one more rendering pass, and it might conflict (even flip-flop) with state updates performed when components mount. - Putting more state in the prerendered html makes more sense. - The features in `redux-persist-crosstab` are still fun-to-have, even though limited to a narrow scope in terms of usefulness. - For now keeping `redux-persist` to enable `redux-persist-crosstab`, but disabling state rehydration from local storage.